Reviewing files that changed from the base of the PR and between 0f075b6 and 6933f06.

• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

• .github/workflows/test.yml (1 hunks)
• package.json (3 hunks)
• packages/ui/package.json (2 hunks)
• packages/ui/src/solidity/remix.node.test.ts (1 hunks)
• packages/ui/src/solidity/remix.ts (1 hunks)

• GitHub Check: check
• GitHub Check: build (stylus, default)
• GitHub Check: build (cairo, default)
• GitHub Check: build (stellar, compile)
• GitHub Check: build (stellar, default)
• GitHub Check: build (solidity, default)
• GitHub Check: mcp
• GitHub Check: semgrep-cloud-platform/scan

package.json (1)

10-10: LGTM: added test:ui script

This nicely scopes UI tests and aligns with the new CI job.

.github/workflows/test.yml (1)

43-52: Make Node version explicit for the UI job

node --import tsx --test depends on recent Node. Either ensure your setup action pins Node ≥18 (preferably 20+) or add an explicit actions/setup-node step here for determinism.

If setup already pins Node ≥20, ignore.

packages/ui/src/solidity/remix.node.test.ts (3)

12-21: LGTM: round‑trip sanity check

Covers the basic path and asserts presence of the code param.

---

23-31: LGTM: deployProxy flag behavior

Correct: only set when upgradeable is true.

---

33-96: LGTM: complex/Unicode contract case

Good coverage for SPDX, imports, inheritance, and Unicode literals (e.g., emoji).

Reviewing files that changed from the base of the PR and between 6933f06 and 28afbb6.

• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

• package.json (2 hunks)
• packages/ui/ava.config.js (1 hunks)
• packages/ui/package.json (3 hunks)
• packages/ui/src/solidity/remix.test.ts (1 hunks)
• packages/ui/src/solidity/remix.ts (1 hunks)
• packages/ui/ts-node-register.cjs (1 hunks)
• packages/ui/tsconfig.test.json (1 hunks)

• packages/ui/tsconfig.test.json
• packages/ui/ava.config.js

• packages/ui/package.json
• package.json

• GitHub Check: build (solidity, default)

packages/ui/src/solidity/remix.ts (2)

16-16: LGTM: using URLSearchParams for code param

This ensures proper percent-encoding of reserved characters.

---

4-14: Fix unbounded spread and remove any casts; resolve lint failures and avoid stack/heap issues

• String.fromCharCode(...bytes) on the full Uint8Array can overflow the call stack for large sources.
• ESLint “Unexpected any” on (globalThis as any) is failing format-lint.
• Use chunked conversion and typed access to global features. This keeps your cross-runtime intent, preserves “trim padding,” and makes lint green.

Apply this diff:

-  // Encode to base64 in a way that works in both browser and Node.
-  const encodedCode = ((): string => {
-    // Prefer browser btoa when available
-    if (typeof (globalThis as any).btoa === 'function') {
-      const bytes = new TextEncoder().encode(code);
-      const binary = String.fromCharCode(...bytes);
-      return (globalThis as any).btoa(binary).replace(/=*$/, '');
-    }
-    // Fallback to Node Buffer
-    return Buffer.from(code, 'utf8').toString('base64').replace(/=*$/, '');
-  })();
+  // Cross‑runtime Base64 over UTF‑8 bytes. Trims "=" padding to keep URLs compact.
+  const encodedCode = ((): string => {
+    const g = globalThis as unknown as {
+      btoa?: (data: string) => string;
+      Buffer?: { from(input: string, encoding: string): { toString(encoding: 'base64'): string } };
+    };
+    // Prefer Node/Buffer when available (works in Node and many bundler environments)
+    if (g.Buffer && typeof g.Buffer.from === 'function') {
+      return g.Buffer.from(code, 'utf8').toString('base64').replace(/=*$/, '');
+    }
+    // Browser path: build the binary string in chunks to avoid call‑stack overflow
+    if (g.btoa && typeof TextEncoder !== 'undefined') {
+      const bytes = new TextEncoder().encode(code);
+      let binary = '';
+      const CHUNK = 0x8000; // 32k chunks
+      for (let i = 0; i < bytes.length; i += CHUNK) {
+        binary += String.fromCharCode(...bytes.subarray(i, i + CHUNK));
+      }
+      return g.btoa(binary).replace(/=*$/, '');
+    }
+    throw new Error('No Base64 encoder available in this environment');
+  })();